8000 fix(napi/parser): lazy deser: do not expose `getElement` method from `NodeArray` by overlookmotel · Pull Request #11777 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(napi/parser): lazy deser: do not expose getElement method from NodeArray #11777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

fix(napi/parser): lazy deser: do not expose getElement method from NodeArray #11777

merged 1 commit into from
Jun 17, 2025
+16 −13

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented Jun 17, 2025 •
edited
Loading

getElement is an internal method. Don't publicly expose it on NodeArray class.

@github-actions github-actions bot added the C-bug Category - Bug label Jun 17, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel changed the title fix(napi/parser): do not expose getElement method from NodeArray fix(napi/parser): lazy deser: do not expose getElement method from NodeArray Jun 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review June 17, 2025 13:33
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
@overlookmotel Graphite App
Copy link
Contributor Author
overlookmotel commented Jun 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
fix(napi/parser): lazy deser: do not expose getElement method from …
a47a6de 
…`NodeArray` (#11777)

`getElement` is an internal method. Don't publicly expose it on `NodeArray` class.
@graphite-app graphite-app bot force-pushed the 06-17-fix_napi_parser_do_not_expose_getelement_method_from_nodearray_ branch from 45a8f62 to a47a6de Compare June 17, 2025 13:49
@graphite-app graphite-app bot merged commit a47a6de into main Jun 17, 2025
15 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
@graphite-app graphite-app bot deleted the 06-17-fix_napi_parser_do_not_expose_getelement_method_from_nodearray_ branch June 17, 2025 13:55
@oxc-bot oxc-bot mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel
0