8000 feat(ast): Add AstKind to ImportAttribute node by therewillbecode · Pull Request #11765 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(ast): Add AstKind to ImportAttribute node #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

therewillbecode
Copy link
Contributor

This PR is part of the ongoing work in #11490.

Adds AstKind to ImportAttribute nodes by removing the entry from the list of exceptions in ast_tools.

Copy link
Contributor
graphite-app bot commented Jun 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request labels Jun 16, 2025
Copy link
codspeed-hq bot commented Jun 16, 2025

CodSpeed Instrumentation Performance Report

Merging #11765 will degrade performances by 12.93%

Comparing therewillbecode:add-astkind-to-importattr (b8651f8) with main (eb9db97)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -12.93%

@camc314 camc314 force-pushed the add-astkind-to-importattr branch from e78065c to b8651f8 Compare June 16, 2025 22:22
@camc314 camc314 mer 9060 ged commit 17f5dbe into oxc-project:main Jun 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0