8000 feat(ast): Add AstKind to TSRestType node by therewillbecode · Pull Request #11752 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(ast): Add AstKind to TSRestType node #11752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

feat(ast): Add AstKind to TSRestType node #11752

merged 2 commits into from
Jun 16, 2025

Conversation

therewillbecode
Copy link
Contributor

This PR is part of the ongoing work in #11490.

Adds AstKind to TSRestType nodes by removing the entry from the list of exceptions in ast_tools.

@graphite-app Graphite App
Copy link
Contributor
graphite-app bot commented Jun 16, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request labels Jun 16, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Jun 16, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11752 will degrade performances by 13.38%

Comparing therewillbecode:add-ast-kind-tsrest (56c14b5) with main (b8237b8)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.38%

@therewillbecode therewillbecode mentioned this pull request Jun 16, 2025
Open
@camc314 camc314 force-pushed the add-ast-kind-tsrest branch from 212ac99 to 2d071db Compare June 16, 2025 19:34
@camc314 camc314 force-pushed the add-ast-kind-tsrest branch from 2d071db to e93a5f6 Compare June 16, 2025 19:34
@camc314 camc314 merged commit 6095438 into oxc-project:main Jun 16, 2025
24 checks passed
@oxc-bot oxc-bot mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therewillbecode @camc314
0