10000 test(editor): remove useless test + improve speed by Sysix · Pull Request #11486 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test(editor): remove useless test + improve speed #11486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: graphite-base/11486
Choose a base branch
from
Open

test(editor): remove useless test + improve speed #11486

wants to merge 1 commit into from

Conversation

Sysix
Copy link
Member
@Sysix Sysix commented Jun 4, 2025 •
edited
Loading

Because VSCode supports the Pull Diagnostics Mode, some tests are now 100% Linter logic and not need to be in the editor.
These tests are already existing on the language server side.

@Sysix Sysix mentioned this pull request Jun 4, 2025
Closed
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Jun 4, 2025
@Sysix Sysix mentioned this pull request Jun 4, 2025
Open
@Sysix Graphite App
Copy link
Member Author
Sysix commented Jun 4, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Jun 4, 2025
@Sysix Sysix mentioned this pull request Jun 4, 2025
Merged
@Sysix Sysix changed the base branch from 06-02-feat_language_server_support_textdocument_diagnostic_ to graphite-base/11486 June 4, 2025 19:28
@Sysix Sysix force-pushed the graphite-base/11486 branch from 618184e to dfd2979 Compare June 5, 2025 18:59
@Sysix Sysix force-pushed the 06-04-test_editor_remove_useless_test_improve_speed branch from 2f70f8a to ddc38e3 Compare June 5, 2025 18:59
@Sysix Sysix changed the base branch from graphite-base/11486 to 06-02-feat_language_server_support_textdocument_diagnostic_ June 5, 2025 18:59
@Sysix Sysix mentioned this pull request Jun 5, 2025
Merged
@Sysix Sysix changed the base branch from 06-02-feat_language_server_support_textdocument_diagnostic_ to graphite-base/11486 June 5, 2025 19:38
@Sysix Sysix force-pushed the graphite-base/11486 branch from dfd2979 to d2f513d Compare June 7, 2025 12:23
@Sysix Sysix force-pushed the 06-04-test_editor_remove_useless_test_improve_speed branch from ddc38e3 to 9432f45 Compare June 7, 2025 12:23
@Sysix Sysix changed the base branch from graphite-base/11486 to 06-02-feat_language_server_support_textdocument_diagnostic_ June 7, 2025 12:23
@Sysix Sysix force-pushed the 06-04-test_editor_remove_useless_test_improve_speed branch from 9432f45 to 7244d41 Compare June 7, 2025 12:27
@Sysix Sysix marked this pull request as ready for review June 7, 2025 12:34
@Sysix Sysix requested a review from camc314 as a code owner June 7, 2025 12:34
@Sysix Sysix force-pushed the 06-02-feat_language_server_support_textdocument_diagnostic_ branch from d2f513d to 06f3ec3 Compare June 9, 2025 13:47
@Sysix Sysix force-pushed the 06-04-test_editor_remove_useless_test_improve_speed branch from 7244d41 to 8b6bd75 Compare June 9, 2025 13:47
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 12, 2025
@Boshen Graphite App
Copy link
Member
Boshen commented Jun 12, 2025 •
edited
Loading

Merge activity

  • Jun 12, 4:37 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 19, 8:53 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 19, 8:54 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app graphite-app bot changed the base branch from 06-02-feat_language_server_support_textdocument_diagnostic_ to graphite-base/11486 June 13, 2025 11:40
@Sysix Sysix force-pushed the graphite-base/11486 branch from 06f3ec3 to e627309 Compare June 13, 2025 11:55
@Sysix Sysix force-pushed the 06-04-test_editor_remove_useless_test_improve_speed branch from 8b6bd75 to 5959a5b Compare June 13, 2025 11:55
@Sysix Sysix changed the base branch from graphite-base/11486 to 06-02-feat_language_server_support_textdocument_diagnostic_ June 13, 2025 11:55
@Sysix Sysix removed the 0-merge Merge with Graphite Merge Queue label Jun 19, 2025
@graphite-app graphite-app bot changed the base branch from 06-02-feat_language_server_support_textdocument_diagnostic_ to graphite-base/11486 June 20, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sysix @Boshen @camc314
0