8000 refactor(language_server): new configuration structure for `initialize` and `workspace/didChangeConfiguration` by Sysix · Pull Request #10890 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(language_server): new configuration structure for initialize and workspace/didChangeConfiguration #10890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(language_server): new configuration structure for initialize and workspace/didChangeConfiguration #10890

wants to merge 1 commit into from
+149 −23

Conversation

Sysix
Copy link
Member
@Sysix Sysix commented May 8, 2025 •
edited
Loading

This PR introduces a new Options structure, which will be used for initialize and workspace/didChangeConfiguration.
This is needed for multi workspace support, or else we will do the less performance-way with sending a server-request to the client.

Updated the docs to reflect how to use the new configuration structure
Still used the old structure as a fallback, because the IntelliJ plugin ❤️

@Sysix Graphite App
Copy link
Member Author
Sysix commented May 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 8, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 8, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10890 will not alter performance

Comparing 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ (a234590) with main (8a3bba8)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix force-pushed the 05-08-ref 8000 actor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from 92e9c2c to eb5d365 Compare May 8, 2025 12:12
@Sysix Sysix mentioned this pull request May 8, 2025
Draft
@Sysix Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch 2 times, most recently from c21ff78 to 2ee56dd Compare May 8, 2025 13:38
@Sysix Sysix marked this pull request as ready for review May 8, 2025 13:40
@Sysix Sysix requested a review from camc314 as a code owner May 8, 2025 13:41
@Sysix Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from 2ee56dd to c25555b Compare May 8, 2025 13:44
@Sysix
Copy link
Member Author
Sysix commented May 8, 2025

@nrayburn-tech I tested it with VSCode extension in main and the language server in this PR.
Everything should still work for the IntelliJ Plugin.
Could you guys start using the new format so we can remove the fallbacks in the future ❤️ ?

@Sysix Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch 2 times, most recently from f4e6654 to 2e33728 Compare May 8, 2025 17:38
@Sysix Sysix mentioned this pull request May 8, 2025
Draft
@Sysix Sysix force-pushed the 05-08-refactor_language_server_new_configuration_structure_for_initialize_and_workspace_didchangeconfiguration_ branch from 2e33728 to a234590 Compare May 8, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

611A @graphite-app graphite-app[bot] graphite-app[bot] left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees
No one assigned
Labels
A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sysix
0