8000 perf(semantic): reuse `Atom` by overlookmotel · Pull Request #10771 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf(semantic): reuse Atom #10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

perf(semantic): reuse Atom #10771

merged 1 commit into from
May 3, 2025

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented May 2, 2025 •
edited
Loading

Follow-on after #10612. Small optimization. We already allocate new_name into SemanticInner's arena. No need to allocate it again - just use the same string.

@github-actions github-actions bot added the A-semantic Area - Semantic label May 2, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label May 2, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 2, 2025 16:52
@overlookmotel overlookmotel removed the request for review from Boshen May 2, 2025 16:52
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 2, 2025 •
edited
Loading

Walkthrough

The changes update the rename_symbol method in the scoping.rs file to first create an Atom from the new symbol name using the allocator and store it in a local variable before replacing the old symbol name in cell.symbol_names. After the replacement, the method removes the old binding from the scope's bindings map using the old name's string slice, then inserts the new binding using the string slice from the newly created Atom. This removes a redundant allocation of a string slice that was previously done inline. The method’s signature, visibility, control flow, and debug assertions remain unchanged. There are no modifications to the declarations of exported or public entities.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a121b7c and 3de1b31.

📒 Files selected for processing (1)
  • crates/oxc_semantic/src/scoping.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/oxc_semantic/src/scoping.rs
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: Benchmark (formatter)
  • GitHub Check: Benchmark (codegen)
  • GitHub Check: Benchmark (minifier)
  • GitHub Check: Test wasm32-wasip1-threads
  • GitHub Check: Test NAPI
  • GitHub Check: Benchmark (semantic)
  • GitHub Check: Test (macos-latest)
  • GitHub Check: Benchmark (isolated_declarations)
  • GitHub Check: Benchmark (transformer)
  • GitHub Check: Test (ubuntu-latest)
  • GitHub Check: Clippy
  • GitHub Check: Benchmark (parser)
  • GitHub Check: Benchmark (lexer)
  • GitHub Check: Conformance
  • GitHub Check: Build Linter Benchmark
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented May 2, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10771 will not alter performance

Comparing 05-02-perf_semantic_reuse_atom_ (3de1b31) with main (40896d4)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 3, 2025
@Boshen Graphite App
Copy link
Member
Boshen commented May 3, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
perf(semantic): reuse Atom (#10771)
3de1b31 
Follow-on after #10612. Small optimization. We already allocate `new_name` into `SemanticInner`'s arena. No need to allocate it again - just use the same string.
@graphite-app graphite-app bot force-pushed the 05-02-perf_semantic_reuse_atom_ branch from a121b7c to 3de1b31 Compare May 3, 2025 00:20
@graphite-app graphite-app bot merged commit 3de1b31 into main May 3, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-02-perf_semantic_reuse_atom_ branch May 3, 2025 00:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 3, 2025
@oxc-bot oxc-bot mentioned this pull request May 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
A-semantic Area - Semantic C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @Boshen
0