8000 perf(minifier): avoid temp `String`s and copying string data by overlookmotel · Pull Request #10733 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf(minifier): avoid temp Strings and copying string data #10733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

perf(minifier): avoid temp Strings and copying string data #10733

merged 1 commit i 8000 nto from
May 1, 2025

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented Apr 30, 2025 •
edited
Loading

Optimize string handling in minifier:

  • Avoid temporary Strings by constructing strings directly in arena using format_atom!.
  • Avoid temporary Strings by concatenating strings in arena with AstBuilder::atom_from_strs_array.
  • Avoid string copying when creating an Atom from a borrowed Cow<'a, str>.
  • Reuse existing slices of text already in arena, rather than copying string data to create new Atoms (replace_known_methods.rs).
  • Reuse existing Atom instead of creating a new one (substitute_alternate_syntax.rs).

@github-actions github-actions bot added A-minifier Area - Minifier C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 30, 2025
This was referenced Apr 30, 2025
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Contributor Author
overlookmotel commented Apr 30, 2025 •
edited 8000
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review April 30, 2025 22:39
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Apr 30, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10733 will not alter performance

Comparing 04-30-perf_minifier_avoid_temp_string_s_and_copying_string_data (c279f16) with main (48c542d)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel mentioned this pull request Apr 30, 2025
Merged
@overlookmotel overlookmotel mentioned this pull request May 1, 2025
Merged
@graphite-app graphite-app bot force-pushed the 04-30-perf_isolated_declaration_avoid_copying_string_data branch from 64a342b to 1d135b6 Compare May 1, 2025 02:11
@graphite-app graphite-app bot requested a review from Dunqing as a code owner May 1, 2025 02:11
@graphite-app graphite-app bot force-pushed the 04-30-perf_minifier_avoid_temp_string_s_and_copying_string_data branch from d1ede38 to 871e9bb Compare May 1, 2025 02:12
@graphite-app graphite-app bot changed the base branch from 04-30-perf_isolated_declaration_avoid_copying_string_data to graphite-base/10733 May 1, 2025 06:42
@graphite-app graphite-app bot force-pushed the 04-30-perf_minifier_avoid_temp_string_s_and_copying_string_data branch from 871e9bb to 15c052e Compare May 1, 2025 06:57
@graphite-app graphite-app bot force-pushed the graphite-base/10733 branch from 1d135b6 to 44f1952 Compare May 1, 2025 06:57
@graphite-app graphite-app bot changed the base branch from graphite-base/10733 to main May 1, 2025 06:57
@graphite-app graphite-app bot force-pushed the 04-30-perf_minifier_avoid_temp_string_s_and_copying_string_data branch from 15c052e to ef1fc7c Compare May 1, 2025 06:57
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 1, 2025 •
edited
Loading

"""

Walkthrough

The changes across several modules in the minifier refactor the handling of string and BigInt literals to consistently use the Atom type and related utilities from oxc_span. In the context conversion logic, BigInt literals are now formatted using the format_atom! macro, and string literals are created by converting them to atoms via self.ast.atom_from_cow. In the peephole optimization routines, string concatenations, casing transformations, character access, replacements, and template literal folding now all produce atomized strings using either atom_from_cow, format_atom!, or atom_from_strs_array, replacing previous direct string or Cow<str> manipulations. Additionally, the assignment target property replacement now uses the binding identifier's name explicitly, and the template literal folding function's signature is updated for explicit lifetimes and atomized string construction. No changes are made to the signatures of exported or public entities, except for the explicit lifetime in one function.

Possibly related PRs

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 358a589 and c279f16.

📒 Files selected for processing (4)
  • crates/oxc_minifier/src/ctx.rs (2 hunks)
  • crates/oxc_minifier/src/peephole/fold_constants.rs (1 hunks)
  • crates/oxc_minifier/src/peephole/replace_known_methods.rs (6 hunks)
  • crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • crates/oxc_minifier/src/ctx.rs
  • crates/oxc_minifier/src/peephole/fold_constants.rs
  • crates/oxc_minifier/src/peephole/substitute_alternate_syntax.rs
  • crates/oxc_minifier/src/peephole/replace_known_methods.rs
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Benchmark (lexer)
  • GitHub Check: Benchmark (isolated_declarations)
  • GitHub Check: Benchmark (parser)
  • GitHub Check: Build Linter Benchmark
  • GitHub Check: Clippy
  • GitHub Check: Conformance
  • GitHub Check: Test wasm32-wasip1-threads
  • GitHub Check: Doc
  • GitHub Check: Test (ubuntu-latest)
  • GitHub Check: Test NAPI
  • GitHub Check: Test (macos-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 1, 2025
@Boshen Graphite App
Copy link
Member
Boshen commented May 1, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel overlookmotel force-pushed the 04-30-perf_minifier_avoid_temp_string_s_and_copying_string_data branch from ef1fc7c to 358a589 Compare May 1, 2025 09:04
@overlookmotel
perf(minifier): avoid temp Strings and copying string data (#10733)
c279f16 
Optimize string handling in minifier:

* Avoid temporary `String`s by constructing strings directly in arena using `format_atom!`.
* Avoid temporary `String`s by concatenating strings in arena with `AstBuilder::atom_from_strs_array`.
* Avoid string copying when creating an `Atom` from a borrowed `Cow<'a, str>`.
* Reuse existing slices of text already in arena, rather than copying string data to create new `Atom`s (`replace_known_methods.rs`).
* Reuse existing `Atom` instead of creating a new one (`substitute_alternate_syntax.rs`).
@graphite-app graphite-app bot force-pushed the 04-30-perf_minifier_avoid_temp_string_s_and_copying_string_data branch from 358a589 to c279f16 Compare May 1, 2025 09:11
@graphite-app graphite-app bot merged commit c279f16 into main May 1, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 04-30-perf_minifier_avoid_temp_string_s_and_copying_string_data branch May 1, 2025 09:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 1, 2025
@coderabbitai coderabbitai bot mentioned this pull request May 1, 2025
Merged
@oxc-bot oxc-bot mentioned this pull request May 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

@Dunqing Dunqing Awaiting requested review from Dunqing

Assignees
No one assigned
Labels
A-minifier Area - Minifier C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @Boshen
0