8000 fix(oxc): prevent DCE step crashing after running define plugin by Boshen · Pull Request #10620 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(oxc): prevent DCE step crashing after running define plugin #10620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix(oxc): prevent DCE step crashing after running define plugin #10620

merged 1 commit into from
Apr 29, 2025

Conversation

Boshen
Copy link
Member
@Boshen Boshen commented Apr 25, 2025 •
edited
Loading

closes #10577
fixes rolldown/rolldown#4261

DCE assumes semantic is correct, but semantic became sync after running the define global, causing the crash.

@Boshen Boshen mentioned this pull request Apr 25, 2025
Merged
@Boshen Boshen marked this pull request as draft April 25, 2025 09:30
@Boshen Graphite App
Copy link
Member Author
Boshen commented Apr 25, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Apr 25, 2025
@Boshen Boshen added the P-high Priority - High label Apr 25, 2025
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Apr 25, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10620 will not alter performance

Comparing 04-25-fix_transformer_plugins_provide_reference_data_when_identifiers_are_replaced (4795059) with main (746b318)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from 04-25-test_transformer_plugins_apply_dce_after_replace_plugin to graphite-base/10620 April 25, 2025 11:02
@graphite-app graphite-app bot force-pushed the graphite-base/10620 branch from 41fce3e to fbd6864 Compare April 25, 2025 11:12
@graphite-app graphite-app bot force-pushed the 04-25-fix_transformer_plugins_provide_reference_data_when_identifiers_are_replaced branch from 3c113d8 to 0f57139 Compare April 25, 2025 11:12
@graphite-app graphite-app bot changed the base branch from graphite-base/10620 to main April 25, 2025 11:13
@graphite-app graphite-app bot force-pushed the 04-25-fix_transformer_plugins_provide_reference_data_when_identifiers_are_replaced branch from 0f57139 to 0a0ae56 Compare April 25, 2025 11:13
@Boshen Boshen assigned Boshen and unassigned Dunqing Apr 27, 2025
@Boshen Boshen force-pushed the 04-25-fix_transformer_plugins_provide_reference_data_when_identifiers_are_replaced branch from 0a0ae56 to f2dee01 Compare April 29, 2025 04:44
@Boshen Boshen marked this pull request as ready for review April 29, 2025 04:44
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@graphite-app Graphite App
Copy link
graphite-app bot commented Apr 29, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 04-25-fix_transformer_plugins_provide_reference_data_when_identifiers_are_replaced branch from f2dee01 to 4795059 Compare April 29, 2025 04:52
@graphite-app graphite-app bot merged commit 4795059 into main Apr 29, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 04-25-fix_transformer_plugins_provide_reference_data_when_identifiers_are_replaced branch April 29, 2025 04:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 29, 2025
@Boshen Boshen changed the title fix(transformer_plugins): provide reference data when identifiers are replaced fix(oxc): prevent DCE step crashing after running define plugin Apr 29, 2025
@oxc-bot oxc-bot mentioned this pull request May 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Boshen Boshen

Labels
C-bug Category - Bug P-high Priority - High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: oxc panicked with define plugin
2 participants
@Boshen @Dunqing
0