FFFF refactor(ast)!: move `type_parameters` field to before `extends` in `TSInterfaceDeclaration` by overlookmotel · Pull Request #10476 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(ast)!: move type_parameters field to before extends in TSInterfaceDeclaration #10476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented Apr 17, 2025
interface Foo<T> extends Bar { }

Move type_parameters field (<T>) to before extends field (Bar), because it comes first.

Copy link
Contributor Author
overlookmotel commented Apr 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

8000

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 17, 2025 13:56
@overlookmotel overlookmotel changed the base branch from 04-17-refactor_ast_estree_move_tsinterfacedeclarationextends_serializer_to_be_with_other_ts_types to graphite-base/10476 April 17, 2025 13:59
@overlookmotel overlookmotel force-pushed the 04-17-refactor_ast_move_type_parameters_field_to_before_extends_in_tsinterfacedeclaration_ branch from cf88abf to dfcefff Compare April 17, 2025 13:59
@overlookmotel overlookmotel changed the base branch from graphite-base/10476 to 04-17-refactor_ast_change_tsinterfacedeclaration_extends_from_option_vec_to_vec_ April 17, 2025 13:59
Copy link
codspeed-hq bot commented Apr 17, 2025

CodSpeed Instrumentation Performance Report

Merging #10476 will not alter performance

Comparing 04-17-refactor_ast_move_type_parameters_field_to_before_extends_in_tsinterfacedeclaration_ (99d82db) with main (7212803)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Apr 18, 2025
Copy link
Member
Dunqing commented Apr 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-17-refactor_ast_change_tsinterfacedeclaration_extends_from_option_vec_to_vec_ branch from f809e9e to eda2c5f Compare April 18, 2025 02:23
graphite-app bot pushed a commit that referenced this pull request Apr 18, 2025
…TSInterfaceDeclaration` (#10476)

```ts
interface Foo<T> extends Bar { }
```

Move `type_parameters` field (`<T>`) to before `extends` field (`Bar`), because it comes first.
@graphite-app graphite-app bot force-pushed the 04-17-refactor_ast_move_type_parameters_field_to_before_extends_in_tsinterfacedeclaration_ branch from dfcefff to 69e1b15 Compare April 18, 2025 02:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 18, 2025
@Boshen Boshen changed the base branch from 04-17-refactor_ast_change_tsinterfacedeclaration_extends_from_option_vec_to_vec_ to graphite-base/10476 April 18, 2025 09:22
graphite-app bot pushed a commit that referenced this pull request Apr 18, 2025
…TSInterfaceDeclaration` (#10476)

```ts
interface Foo<T> extends Bar { }
```

Move `type_parameters` field (`<T>`) to before `extends` field (`Bar`), because it comes first.
@graphite-app graphite-app bot force-pushed the 04-17-refactor_ast_move_type_parameters_field_to_before_extends_in_tsinterfacedeclaration_ branch from 69e1b15 to 6890ad1 Compare April 18, 2025 09:46
@graphite-app graphite-app bot force-pushed the graphite-base/10476 branch from eda2c5f to 7212803 Compare April 18, 2025 09:46
@graphite-app graphite-app bot changed the base branch from graphite-base/10476 to main April 18, 2025 09:47
…TSInterfaceDeclaration` (#10476)

```ts
interface Foo<T> extends Bar { }
```

Move `type_parameters` field (`<T>`) to before `extends` field (`Bar`), because it comes first.
@graphite-app graphite-app bot force-pushed the 04-17-refactor_ast_move_type_parameters_field_to_before_extends_in_tsinterfacedeclaration_ branch from 6890ad1 to 99d82db Compare April 18, 2025 09:47
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 18, 2025
@graphite-app graphite-app bot merged commit 99d82db into main Apr 18, 2025
30 checks passed
@graphite-app graphite-app bot deleted the 04-17-refactor_ast_move_type_parameters_field_to_before_extends_in_tsinterfacedeclaration_ branch April 18, 2025 10:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-parser Area - Parser A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0