8000 refactor(ast/estree): improve readability of custom serializers by overlookmotel · Pull Request #10474 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor(ast/estree): improve readability of custom serializers #10474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

refactor(ast/estree): improve readability of custom serializers #10474

merged 1 commit into from
Apr 17, 2025

Conversation

overlookmotel
Copy link
Contributor
@overlookmotel overlookmotel commented Apr 17, 2025 •
edited
Loading

Null(()).serialize(serializer) is clearer than ().serialize(serializer).

@github-actions github-actions bot added the A-ast Area - AST label Apr 17, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 17, 2025 13:23
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 17, 2025
@overlookmotel Graphite App
Copy link
Contributor Author
overlookmotel commented Apr 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel
refactor(ast/estree): improve readability of custom serializers (#10474)
852c8a7 
`Null(()).serialize(serializer)` is clearer than `().serialize(serializer)`.
@graphite-app graphite-app bot force-pushed the 04-17-refactor_ast_estree_improve_readability_of_custom_serializers branch from 533a32f to 852c8a7 Compare April 17, 2025 13:30
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Apr 17, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10474 will not alter performance

Comparing 04-17-refactor_ast_estree_improve_readability_of_custom_serializers (852c8a7) with main (1952e30)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit 852c8a7 into main Apr 17, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-17-refactor_ast_estree_improve_readability_of_custom_serializers branch April 17, 2025 13:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 17, 2025
@oxc-bot oxc-bot mentioned this pull request Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel
0