8000 feat(parser): a rest parameter cannot have an initializer by Boshen · Pull Request #10467 · oxc-project/oxc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(parser): a rest parameter cannot have an initializer #10467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

feat(parser): a rest parameter cannot have an initializer #10467

merged 1 commit into from
Apr 17, 2025

Conversation

Boshen
Copy link
Member
@Boshen Boshen commented Apr 17, 2025 
function b(...[...foo = []]: string[]) { }
                      ^^^^

@Boshen Boshen requested a review from Dunqing as a code owner April 17, 2025 11:03
Base automatically changed from 04-17-feat_parser_error_for_const_.a_b_ to main April 17, 2025 11:03
@Boshen Boshen mentioned this pull request Apr 17, 2025
Merged
@Boshen Graphite App
Copy link
Member Author
Boshen commented Apr 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic C-enhancement Category - New feature or request labels Apr 17, 2025
@Boshen Boshen mentioned this pull request Apr 17, 2025
Open
@codspeed-hq CodSpeed HQ
Copy link
codspeed-hq bot commented Apr 17, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #10467 will not alter performance

Comparing 04-17-feat_parser_a_rest_parameter_cannot_have_an_initializer (588da69) with main (c8336dd)

Summary

✅ 36 untouched benchmarks

@graphite-app Graphite App
Copy link
graphite-app bot commented Apr 17, 2025 •
edited
Loading

Merge activity

@Boshen
feat(parser): a rest parameter cannot have an initializer (#10467)
8000
588da69 
```js
function b(...[...foo = []]: string[]) { }
                      ^^^^
```
@graphite-app graphite-app bot force-pushed the 04-17-feat_parser_a_rest_parameter_cannot_have_an_initializer branch from 87d7607 to 588da69 Compare April 17, 2025 11:14
@graphite-app graphite-app bot merged commit 588da69 into main Apr 17, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-17-feat_parser_a_rest_parameter_cannot_have_an_initializer branch April 17, 2025 11:20
@oxc-bot oxc-bot mentioned this pull request Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
A-parser Area - Parser A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen
0