[feature/feedback-url] Open URL when selecting "Send feedback" #1035

felix-schwarz · 2021-09-13T15:35:17Z

Description

Adds branding.send-feedback-url class setting to provide a URL to open when selecting Send feedback. The string supports the same template elements as http.user-agent.

Branding.plist example:

<key>branding.send-feedback-url</key>
<string>https://www.owncloud.com/?appVersion={{app.version}}</string>

Template for composed emails - and what's available for `branding.send-feedback-url`

If branding.send-feedback-url is not provided, Send feedback would compose an empty email to branding.send-feedback-address with the following subject:

{{app.version}} ({{app.build}}) BUILD_TYPE APP_NAMEAPP_SUFFIX

These placeholders are supported by branding.send-feedback-url:

{{app.version}}
{{app.build}}

These are not supported and would need to be hardcoded into branding.send-feedback-url:

BUILD_TYPE (release or beta)
APP_NAME (f.ex. ownCloud)
APP_SUFFIX (either empty or -emm).

Related Issue

https://github.com/owncloud/enterprise/issues/4726

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

- factor out app-specific VendorServices into app, to allow calls to openURL() - add support for new Branding class setting `branding.send-feedback-url` with template support

CLAassistant · 2021-09-13T15:35:20Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jesmrec · 2021-09-15T15:28:15Z

QA checks:

url means branding.send-feedback-url
address means branding.send-feedback-address

address contains an email address, url non existing -> Feedback sends email to the address
address contains an email address, url existing and empty -> Feedback sends email to the address
address contains an email address, url existing containing an URL -> URL is open
address empty, url existing containing an URL -> URL is open
address non existing, url existing containing an URL -> URL is open
Check Send feedback with regular app, no branded client

iOS13, iOS14

8000

jesmrec · 2021-09-15T15:38:13Z

note for myself:

branding.send-feedback-url intended to have more priority than branding.send-feedback-address

Testing was done using such premise

jesmrec · 2021-09-15T15:47:23Z

One question about the description above:

If branding.send-feedback-url is not provided, Send feedback would compose an empty email to branding.send-feedback-address with the following subject:

{{app.version}} ({{app.build}}) BUILD_TYPE APP_NAMEAPP_SUFFIX

as you described, BUILD_TYPE and APP_NAMEAPP_SUFFIX must be hardcoded into branding.send-feedback-url

but, the email is only composed if branding.send-feedback-url is not provided.

@felix-schwarz could you clarify, please? thanks in advance.

hosy · 2021-09-16T13:37:03Z

@jesmrec I do not understand your last question. Please can you describe in detail?

Composing a mail is working like before this PR. If branding.send-feedback-url was given, composing a email inside the app is not possible and the branding.send-feedback-url will be opened, with the (optional) hardcoded parameters BUILD_TYPE and APP_NAMEAPP_SUFFIX.

felix-schwarz · 2021-09-16T15:06:37Z

@jesmrec Under Template for composed emails…, I tried to document:

what the contents of the email that is composed by Send feedback looks like if branding.send-feedback-url is not used
when using branding.send-feedback-url: how to mimic that content as closely as possible using template support for that config parameter - and what is not available as template fields there.

Since branding.send-feedback-url will only be used for specific apps, hard coding BUILD_TYPE, APP_NAME and APP_SUFFIX into the provided URL should not be a problem.

jesmrec · 2021-09-17T07:20:50Z

Thanks for the response.

Testing is complete, then.

Approved on my side

- remove unused VendorServices.swift duplicate

1ee9972

- factor out app-specific VendorServices into app, to allow calls to openURL() - add support for new Branding class setting `branding.send-feedback-url` with template support

felix-schwarz added this to the 11.8.0-Current milestone Sep 13, 2021

felix-schwarz requested review from hosy and jesmrec September 15, 2021 08:42

hosy changed the base branch from milestone/11.8 to milestone/11.7.1 September 15, 2021 11:51

hosy approved these changes Sep 15, 2021

View reviewed changes

hosy modified the milestones: 11.8.0-Current, 11.7.1-Fix Sep 15, 2021

jesmrec approved these changes Sep 17, 2021

View reviewed changes

jesmrec added the Approved by QA Approved by QA label Sep 17, 2021

hosy merged commit 4461227 into milestone/11.7.1 Sep 17, 2021

delete-merged-branch bot deleted the feature/feedback-url branch September 17, 2021 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[feature/feedback-url] Open URL when selecting "Send feedback" #1035

[feature/feedback-url] Open URL when selecting "Send feedback" #1035

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[feature/feedback-url] Open URL when selecting "Send feedback" #1035

Uh oh!

Uh oh!

Description

Template for composed emails - and what's available for branding.send-feedback-url

Related Issue

Types of changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Template for composed emails - and what's available for `branding.send-feedback-url`