8000 [fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad by hosy · Pull Request #905 · owncloud/ios-app · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

[fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2021
Merged

[fix/pdf-thumbnailview-position] PDF thumbnail view position on the iPad #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ada4fc0
Fixing the thumbnail view position on the iPad in portrait view
hosy Feb 22, 2021
5ab6ca5
added changelog issue
hosy Feb 23, 2021
53f0874
Calens changelog updated
hosy Feb 23, 2021
24bdf7c
fixed QA finding (jumpy thumbnail view on iPhone)
hosy Mar 1, 2021
462ef13
isPortrait mode is not working and removed it with size class
hosy Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,26 @@
Changelog for ownCloud iOS Client [unreleased] (UNRELEASED)
=======================================
The following sections list the changes in ownCloud iOS Client unreleased relevant to
ownCloud admins and users.

[unreleased]: https://github.com/owncloud/client/compare/v11.5.1...master

Summary
-------

* Bugfix - PDF thumbnail view position on the iPad: [#905](https://github.com/owncloud/ios-app/pull/905)

Details
-------

* Bugfix - PDF thumbnail view position on the iPad: [#905](https://github.com/owncloud/ios-app/pull/905)

Fixed the position of the PDF thumbnail view on the iPad from the bottom to the right position to
get more visible PDF content and to prevent enabling the iOS app switcher when scrolling throw
the thumbnail view.

https://github.com/owncloud/ios-app/pull/905

Changelog for ownCloud iOS Client [11.5.1] (2020-02-17)
=======================================
The following sections list the changes in ownCloud iOS Client 11.5.1 relevant to
Expand Down
5 changes: 5 additions & 0 deletions changelog/unreleased/905
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: PDF thumbnail view position on the iPad

Fixed the position of the PDF thumbnail view on the iPad from the bottom to the right position to get more visible PDF content and to prevent enabling the iOS app switcher when scrolling throw the thumbnail view.

https://github.com/owncloud/ios-app/pull/905
3 changes: 2 additions & 1 deletion ownCloud/Client/Viewer/PDF/PDFViewerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ class PDFViewerViewController: DisplayViewController, DisplayExtension {
if gotoPageNotificationObserver != nil {
NotificationCenter.default.removeObserver(gotoPageNotificationObserver!)
}

}

private var didSetupView : Bool = false
Expand Down Expand Up @@ -327,7 +328,7 @@ class PDFViewerViewController: DisplayViewController, DisplayExtension {
// MARK: - Private helpers

private func setThumbnailPosition() {
if UIScreen.main.traitCollection.verticalSizeClass == .regular {
if !UIDevice.current.isIpad, UIScreen.main.traitCollection.verticalSizeClass == .regular {
self.thumbnailViewPosition = .bottom
} else {
self.thumbnailViewPosition = .right
Expand Down
0