feat: container signals will reach ocis #11405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
2403905
approved these changes
Jun 6, 2025
7BE3
ownclouders
pushed a commit
that referenced
this pull request
Jun 10, 2025
feat: container signals will reach ocis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix signal delivery in the docker containers for the deployment examples. This will allow a clean shutdown process in the oCIS containers.
Related Issue
#11399
Motivation and Context
Signals weren't being delivered to oCIS. Docker needed to kill the containers because they didn't stop.
How Has This Been Tested?
Manually tested. Just start the containers and stop them after a while. Shutting down the whole docker stack takes around 3 seconds, so docker doesn't need to kill the containers.
Screenshots (if appropriate):
Types of changes
Checklist: