feat: office deployment hardening #11339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Pinging @mmattel in case this is merged because it's probably doc relevant. |
|
@jp, yes this is docs relevant and many thanks for taking care. This eases the configuration and setup. I did an important change for collabora recently and added a changelog. Could you also add a changelog for this PR. Normally we dont do this for |
Closed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Harden office installation:
In general, you shouldn't need to change anything. If the installation worked before these changes, it should also work with this PR without touching anything else.
For new installations, you can still go through the regular installation steps. The only change is that you won't need to setup a domain for the wopiserver (so less things to do)
Note that this is just deployment changes and there is no code change involved.
Related Issue
#11325
Motivation and Context
Using both ip filters and the proof keys, it should help to harden the installation by making sure the requests come from trusted sources. Requests coming from untrusted sources should be rejected or ignored
How Has This Been Tested?
Quick test by uploading a .docx file and edit it in the office editor (both Collabora and OnlyOffice). There are no problems with the regular scenario and the changes are saved properly.
Screenshots (if appropriate):
Types of changes
Checklist: