8000 [tests-only][full-ci] use store for drives by saw-jan · Pull Request #11000 · owncloud/ocis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[tests-only][full-ci] use store for drives #11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2025
Merged

[tests-only][full-ci] use store for drives #11000

merged 4 commits into from
Feb 20, 2025

Conversation

saw-jan
Copy link
Member
@saw-jan saw-jan commented Feb 12, 2025 •
edited
Loading

Description

I have added a store to save all drives (personal, shares and project) and use it to get the necessary properties. If the requested drive is unavailable in the store then a request to me/drives is made to get the drives.

I have also made the changes to the user store and user deletion flow. These stores should work with the local and remote server setup.

Related Issue

How Has This Been Tested?

  • test environment: 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Feb 12, 2025
@saw-jan saw-jan force-pushed the test/fix-test-code branch 4 times, most recently from dd64371 to bdf66ec Compare February 13, 2025 11:05
@saw-jan saw-jan changed the title [do-not-merge][tests-only][full-ci] check update quote test scenarios [do-not-merge][tests-only][full-ci] check update quota test scenarios Feb 13, 2025
@saw-jan saw-jan force-pushed the test/fix-test-code branch 3 times, most recently from 4542aa1 to fe46ce1 Compare February 17, 2025 12:05
saw-jan
saw-jan commented Feb 17, 2025
View reviewed changes
@saw-jan saw-jan force-pushed the test/fix-test-code branch 7 times, most recently from 093aa82 to e311cdb Compare February 19, 2025 04:18
@saw-jan saw-jan force-pushed the test/fix-test-code branch 2 times, most recently from aaf7131 to 69a53ba Compare February 19, 2025 06:13
@saw-jan saw-jan changed the title [do-not-merge][tests-only][full-ci] check update quota test scenarios [tests-only][full-ci] check update quota test scenarios Feb 19, 2025
@saw-jan saw-jan marked this pull request as ready for review February 19, 2025 08:06
@saw-jan saw-jan changed the title [tests-only][full-ci] check update quota test scenarios [tests-only][full-ci] use store for drives Feb 19, 2025
saw-jan
saw-jan commented Feb 19, 2025
View reviewed changes
tests/acceptance/features/apiGraphUserGroup/editUser.feature
@@ -37,7 +37,7 @@ Feature: edit user
Examples:
| action description | user | http-status-code | new-user |
| change to a valid user name | Lionel | 200 | Lionel |
| user name characters | a*!_+-& | 200 | a*!_+-& |
| user name characters | a*!_-& | 200 | a*!_-& |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test scenario for + will be done in #11032

nabim777
nabim777 reviewed Feb 19, 2025
View reviewed changes
PrajwolAmatya
PrajwolAmatya reviewed Feb 19, 2025
View reviewed changes
anon-pradip
anon-pradip reviewed Feb 19, 2025
View reviewed changes
prashant-gurung899
prashant-gurung899 reviewed Feb 19, 2025
View reviewed changes
@saw-jan saw-jan mentioned this pull request Feb 19, 2025
Open
@anon-pradip
Copy link
Contributor

LGTM 👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

PrajwolAmatya
PrajwolAmatya approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor
@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan
Copy link
Member Author
saw-jan commented Feb 20, 2025

Let's wait for PR #11037 to be merged so that dev team can debug the root cause.

amrita-shrestha
amrita-shrestha reviewed Feb 20, 2025
View reviewed changes
amrita-shrestha
amrita-shrestha requested changes Feb 20, 2025
View reviewed changes
@saw-jan
Copy link
Member Author
saw-jan commented Feb 20, 2025 •
edited
Loading

Let's wait for PR #11037 to be merged so that dev team can debug the root cause.

I have collected the necessary logs (See #10603 (comment)) so this is good to be merged

@saw-jan saw-jan merged commit a17973f into master Feb 20, 2025
4 checks passed
@saw-jan saw-jan deleted the test/fix-test-code branch February 20, 2025 08:52
ownclouders pushed a commit that referenced this pull request Feb 20, 2025
@saw-jan
Merge pull request #11000 from owncloud/test/fix-test-code
3fc3e9f 
[tests-only][full-ci] use store for drives
This was referenced Feb 24, 2025
Merged
Merged
@saw-jan saw-jan mentioned this pull request Jun 4, 2025
6D40
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anon-pradip anon-pradip anon-pradip left review comments

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@S-Panta S-Panta Awaiting requested review from S-Panta

@nabim777 nabim777 Awaiting requested review from nabim777

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saw-jan @anon-pradip @prashant-gurung899 @amrita-shrestha @nabim777 @PrajwolAmatya
0