Use window aspect ratio for VR preview rather than hardcoded 16:9 #1571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuprynowicz
approved these changes
May 29, 2025
| @@ -214,14 +214,16 @@ void HmdDisplayPlugin::internalPresent() { | |||
| float newWidth = sourceSize.x - shiftLeftBy; | |||
|
|
|||
| // Experimentally adjusted the region presented in preview to avoid seeing the masked pixels and recenter the center... | |||
| static float SCALE_WIDTH = 0.8f; | |||
| static float SCALE_WIDTH = 1.0f; | |||
There was a problem hiding this comment.
We need to test this on windows to see if it won't show VR headset eyepiece stencil.
|
On some window proportions there are issues with cutout being visible, and part of second eye view being visible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scales the desktop VR preview to the window aspect ratio and slightly increases the preview FOV.
SCALE_WIDTHneeds testing on SteamVR with the OpenVR plugin, a value of 1.0 doesn't cause a problem in OpenXR (currently doesn't have corner clipping) or OpenComposite/xrizer (the corner clipping is very small and only visible when the window is near a 1:1 aspect ratio), but SteamVR's more advanced corner clipping might be visible. In that case, it can be reverted back to 0.8.