Move group management to table #8212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a subtle regression in nested group modals wherein closing a nested modal does not bring the focus back automatically to the parent modal - we render each modal as a separate top level dialog; reakit suggests the child modal to be rendered inside the parent to ensure proper focus on close (https://reakit.io/docs/dialog/#nested-dialogs). Fixing this would require changing Dialogs and Modal component. I was wondering if we can live with this slight regression for a couple weeks until the modal component is migrated to Radix (my next big task), which will anyway need some re-implementation. |
tommoor
reviewed
Jan 9, 2025
Add 'External ID' in menu when present
tommoor
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7484
This PR moves group management page to use
Tablecomponent. Along the way, group modals that were scattered in many files are consolidated into a singleGroupDialogsfile.