fix: Use configured proxy for OIDC server-to-server requests #8776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new OIDCStrategy that leverages a configured HTTPS proxy for server-to-server OIDC requests. It replaces global monkey-patching of the passport-oauth2 Strategy with a dedicated subclass implementation and updates the fetch import in the passport utility.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/oidc/server/auth/OIDCStrategy.ts | Added a new subclass extending Strategy to set a configured HTTPS proxy and override methods. |
| plugins/oidc/server/auth/oidc.ts | Replaced Strategy monkey-patching with the new OIDCStrategy to ensure proxy support. |
| server/utils/passport.ts | Updated the fetch import to use a local wrapper instead of node-fetch. |
Files not reviewed (1)
- package.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8775