feat: Restore document search in link toolbar #8581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR restores the document search functionality within the link toolbar while refactoring the LinkEditor component from a class-based to a functional approach. Key changes include:
- Converting LinkEditor.tsx from a class component to a functional component with hooks.
- Integrating document search results and suggestions using a new suggestions menu.
- Minor styling updates in Input.tsx and enhancements in context menu components for pointer interactions.
Reviewed Changes
| File | Description |
|---|---|
| app/editor/components/LinkEditor.tsx | Refactored to a functional component; added document search and suggestion UI. |
| app/editor/components/Input.tsx | Updated placeholder styling using polished’s transparentize. |
| app/components/ContextMenu/MenuItem.tsx | Added onPointerMove event support. |
| app/editor/components/MentionMenu.tsx | Modified the useRequest callback for fetching suggestions. |
| app/editor/components/SuggestionsMenuItem.tsx | Added onPointerMove prop forwarding to improve hover interactions. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| documents: Document[]; | ||
| users: User[]; | ||
| }>( | ||
| const { loading, request } = useRequest( |
There was a problem hiding this comment.
The previous callback returned an object containing documents and users, but the updated implementation only maps these values without returning them. This change might break downstream logic if it depends on the returned data.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back due to popular demand 😆
closes #8444