8000 Remove trailing spaces from search query by apoorv-mishra · Pull Request #7314 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove trailing spaces from search query #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2024
Merged

Remove trailing spaces from search query #7314

merged 2 commits into from
Jul 27, 2024

Conversation

apoorv-mishra
Copy link
Member
@apoorv-mishra apoorv-mishra commented Jul 26, 2024 •
edited
Loading

Closes #7308

@auto-assign auto-assign bot requested a review from tommoor July 26, 2024 16:21
@tommoor
Copy link
Member
tommoor commented Jul 26, 2024

We have extensive tests for SearchHelper because it's complex, I think a regression test is justified here

@tommoor tommoor merged commit f56f240 into main Jul 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SequelizeDatabaseError: there is no escaped character: "env\"
2 participants
@apoorv-mishra @tommoor
0