fix: Rare loop of storage events between tabs causing flickering UI #7996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
commented
Nov 20, 2024
| @@ -324,6 +307,10 @@ class UiStore { | |||
| theme: this.theme, | |||
| }; | |||
| } | |||
|
|
|||
| private persist = () => { | |||
| Storage.set(UI_STORE, this.asJson); | |||
There was a problem hiding this comment.
Overall this solution is pretty dated, but we'll keep it for now for backwards compat
tommoor
commented
Nov 21, 2024
| @@ -134,10 +135,6 @@ class UiStore { | |||
| this.tocVisible = newData.tocVisible; | |||
| } | |||
| }); | |||
|
|
|||
| autorun(() => { | |||
There was a problem hiding this comment.
Removing the autorun means we won't write to storage unless the user in this tab interacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to rapidly toggle some UI elements faster than these changes can be communicated between tabs via the
"storage"event. When this happens it can cause an infinite loop that can only be stopped by closing a tab.