8000 Allow passing subdomain as `null` by apoorv-mishra · Pull Request #5289 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow passing subdomain as null #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

Allow passing subdomain as null #5289

merged 1 commit into from
May 2, 2023

Conversation

apoorv-mishra
Copy link
Member

Closes #5287

@auto-assign auto-assign bot requested a review from tommoor May 2, 20 A057 23 09:16
@apoorv-mishra apoorv-mishra changed the title Allow null for subdomain Allow passing subdomain as null May 2, 2023
@apoorv-mishra apoorv-mishra merged commit 3d6a875 into main May 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/5287/allow-null-for-subdomain branch May 2, 2023 12:49
tommoor pushed a commit that referenced this pull request May 6, 2023
@apoorv-mishra @tommoor
fix: allow null for subdomain (#5289)
3c4daca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subdomain: Expected string, received null
2 participants
@apoorv-mishra @tommoor
0