8000 Keep nested docs in shared sidebar collapsed by default by apoorv-mishra · Pull Request #5208 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keep nested docs in shared sidebar collapsed by default #5208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 20, 2023
Merged

Keep nested docs in shared sidebar collapsed by default #5208

merged 3 commits into from
Aug 20, 2023

Conversation

apoorv-mishra
Copy link
Member

Closes #5123

@auto-assign auto-assign bot requested a review from tommoor April 16, 2023 14:17
@tommoor
Copy link
Member
tommoor commented Apr 22, 2023

I think it probably goes too far, if you look at the existing guide as an example:

image

This is a lot to display at once, but this is also not very nice:

image

Perhaps the right thing is to open the first level and close everything else?

image

@almereyda
Copy link

Showing only the first-level of nesting looks also much cleaner to me.

Does the UI remember which lower levels were expanded, in case of a page reload or browsing to another page and back here?

@apoorv-mishra
Copy link
Member Author

Does the UI remember which lower levels were expanded, in case of a page reload or browsing to another page and back here?

No, it doesn't remember the expanded levels across multiple sessions unless you click a particular document in sidebar.

@apoorv-mishra apoorv-mishra force-pushed the fix/5123/shared-sidebar-collapsed-default branch from 8a891f8 to f4579f3 Compare June 18, 2023 05:38
@tommoor tommoor merged commit 4354e10 into main Aug 20, 2023
@tommoor tommoor deleted the fix/5123/shared-sidebar-collapsed-default branch August 20, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collapse nested docs in shared sidebar by default
3 participants
@apoorv-mishra @tommoor @almereyda
0