fix: Various compounding memory leaks in editor #5950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoor
commented
Oct 5, 2023
| @@ -171,7 +171,7 @@ | |||
| "prosemirror-state": "^1.4.3", | |||
| "prosemirror-tables": "^1.3.2", | |||
| "prosemirror-transform": "^1.7.3", | |||
| "prosemirror-view": "^1.31.3", | |||
| "prosemirror-view": "^1.32.0", | |||
There was a problem hiding this comment.
Get this fix: ProseMirror/prosemirror-view@f25f340
| const containerBounds = useComponentSize( | ||
| document.body.querySelector("#full-width-container") | ||
| ); | ||
| const documentBounds = props.view.dom.getBoundingClientRect(); |
There was a problem hiding this comment.
Don't use cached bounds for document, and one less ResizeObserver
| @@ -14,48 +14,44 @@ const defaultRect = { | |||
| export default function useComponentSize( | |||
| element: HTMLElement | null | |||
| ): DOMRect | typeof defaultRect { | |||
| const [size, setSize] = useState(element?.getBoundingClientRect()); | |||
| const [size, setSize] = useState(() => element?.getBoundingClientRect()); | |||
There was a problem hiding this comment.
Don't calculate getBoundingClientRect on ever render
| ); | ||
| }); | ||
| const sizeObserver = new ResizeObserver(() => { | ||
| element?.dispatchEvent(new CustomEvent("resize")); |
There was a problem hiding this comment.
Custom event allows handling to be in one handleResize function
| @@ -302,6 +302,7 @@ export class Editor extends React.PureComponent< | |||
|
|
|||
| public componentWillUnmount(): void { | |||
| window.removeEventListener("theme-changed", this.dispatchThemeChanged); | |||
| this.view.destroy(); | |||
There was a problem hiding this comment.
Memory leak, not calling destroy on NodeView s on unmount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5939
closes #5929