8000 Add LinkedIn embed by prikshitsingh24 · Pull Request #5933 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add LinkedIn embed #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 18, 2023
Merged

Add LinkedIn embed #5933

merged 5 commits into from
Oct 18, 2023

Conversation

prikshitsingh24
Copy link
Contributor

added linkedIn embed which looks something like this:
Screenshot from 2023-10-04 23-51-46

@auto-assign auto-assign bot requested a review from tommoor October 4, 2023 18:24
@CLAassistant
Copy link
CLAassistant commented Oct 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tommoor
tommoor reviewed Oct 4, 2023
View reviewed changes
@prikshitsingh24
Copy link
Contributor Author

I have accepted the CLA but it is still showing agreement not signed, do i need to do something else?

@tommoor
Copy link
Member
tommoor commented Oct 9, 2023

Looks like it's stuck, it happens – no worries as it's a non-blocking check

@tommoor
Copy link
Member
tommoor commented Oct 12, 2023

I don't love that while loop, this is immediately the most complex embed in the system which makes me think that logic can be avoided. In LinkedIn.ENABLED it's possible to specify multiple regex which might simplify and allow writing tests.

Do you have some examples of urls that should match here? I'm not familiar with LinkedIn

@prikshitsingh24
Copy link
Contributor Author
prikshitsingh24 commented Oct 12, 2023 •
edited
Loading

Yes, there are two types of urls : https://www.linkedin.com/posts/github_asakawa-activity-7117896142612267009-Cg_x?utm_source=share&utm_medium=member_desktop , https://www.linkedin.com/posts/jaredspa_generativeai-aiskills-futureofwork-ugcPost-7113555729428480000-dVrv?utm_source=share&utm_medium=member_desktop

and the embed url: https://www.linkedin.com/embed/feed/update/urn:li:share:7117157513422090241

@zeekhuge
Copy link
zeekhuge commented Oct 13, 2023 •
edited
Loading

@prikshitsingh24 Whats the difference between those 2 urls, ie, between the following URLs

  1. https://www.linkedin.com/posts/github_asakawa-activity-7117896142612267009-Cg_x
  2. https://www.linkedin.com/posts/jaredspa_generativeai-aiskills-futureofwork-ugcPost-7113555729428480000-dVrv

They look exactly the same (in terms of URL structure).

tommoor
tommoor reviewed Oct 17, 2023
View reviewed changes
Copy link
Member
@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now, just need to fix the name – it's styled with a capitalized "I"

@tommoor tommoor merged commit bb8fd93 into outline:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor 56D3 tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prikshitsingh24 @CLAassistant @tommoor @zeekhuge @PrikshitSingh-AL
0