8000 feat: Native video display by tommoor · Pull Request #5866 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Native video display #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 29, 2023
Merged

feat: Native video display #5866

merged 9 commits into from
Sep 29, 2023

Conversation

tommoor
Copy link
Member
@tommoor tommoor commented Sep 22, 2023 •
edited
Loading
  • Adds support for displaying inline videos, and a video option to the slash menu.
  • Refactors image resizing logic to be reusable with video node.
  • Refactors image captions to be reusable with video node.

closes #3130

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 22, 2023
View reviewed changes
shared/editor/lib/FileHelper.ts
resolve({ width: video.videoWidth, height: video.videoHeight });
};
video.>
video.src = URL.createObjectURL(file);

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
@tommoor tommoor force-pushed the tom/3130-native-video-embeds branch from 77c31ef to 71a6ffb Compare September 23, 2023 18:03
@tommoor tommoor merged commit f4fd9da into main Sep 29, 2023
@tommoor tommoor deleted the tom/3130-native-video-embeds branch September 29, 2023 00:28
@Limezy
Copy link
Contributor
Limezy commented Sep 29, 2023

Many thanks for that great addition.
Would it be possible to use the same native player for audio .mp3 files ?
Would it be possible to make a link to a timestamp of that video / audio file ?

@tommoor
Copy link
Member Author
tommoor commented Sep 29, 2023

I plan to work on a custom video player but we'll see how much time is available for that ha
8000

@Limezy
Copy link
Contributor
Limezy commented Sep 29, 2023

I am surprised that the native player component you have used can't read mp3 !

@StarWhiz
Copy link
StarWhiz commented Oct 2, 2023

Thank you for making this feature which replicates what can be done on Confluence!

Since I'm a noob and don't know how to build the docker image to try this out, can I ask that a new built image with new tag be published eventually?

@tommoor
Copy link
Member Author
tommoor commented Oct 3, 2023

Available in https://github.com/outline/outline/releases/tag/v0.72.0

@HsunGong
Copy link

@tommoor could you please add mp3/wav support as we also need to play it just like videos.

Meanwhile, it seems difficult for those who is not familiar with the code.

Thanks a lot!

@Limezy
Copy link
Contributor
Limezy commented Dec 25, 2023

Yes would love sound support too !
Thanks 😊

@HsunGong
Copy link

I was wondering, if we can use the video component to play audios? Or just built-in html5 player?

@jonnymccullagh
Copy link

+1 for a player (html5) for uploaded audio files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native video embeds
5 participants
@tommoor @Limezy @StarWhiz @HsunGong @jonnymccullagh
0