fix: Incorrect error shown to user when connection limit is reached #5695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! It looks like you didn't provide much information here. Please consider adding more details about the issue / pr or it will be automatically closed. Thanks for helping us maintain the project! |
tommoor
commented
Aug 16, 2023
|
|
||
| @trace() | ||
| export class ConnectionLimitExtension implements Extension { | ||
| /** | ||
| * Map of documentId -> connection count | ||
| */ | ||
| connectionsByDocument: Map<string, number> = new Map(); | ||
| connectionsByDocument: Map<string, Set<string>> = new Map(); |
There was a problem hiding this comment.
Updated to track specific socketId s instead of a number
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported through support that the error was confusing in this condition.