chore: Improves li 8000 nting rule to catch mishandled promises #5506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3276a1d to
6f8a77a
Compare
| }, 100); | ||
| // setTimeout is needed here because SearchQuery is saved asynchronously | ||
| // in order to not slow down the response time. | ||
| await new Promise((resolve) => setTimeout(resolve, 100)); |
There was a problem hiding this comment.
We already have a util for this in server/utils/timers.ts
There was a problem hiding this comment.
gtk, I don't feel too bad about a dupe here with it being tests
| @@ -4,6 +4,7 @@ import * as React from "react"; | |||
| import { useTranslation } from "react-i18next"; | |||
| import styled from "styled-components"; | |||
| import Avatar from "~/components/Avatar"; | |||
| import { AvatarSize } from "~/components/Avatar/Avatar"; | |||
There was a problem hiding this comment.
These changes are unrelated to linting?
| @@ -21,6 +21,7 @@ | |||
| "strictNullChecks": true, | |||
| "noEmit": true, | |||
| "skipLibCheck": true, | |||
| "ignoreDeprecations": "5.0", | |||
There was a problem hiding this comment.
Remember this as a temporary fix.
|
Oops! This is already merged 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately having this lint rule work properly required upgrading typescript and eslint.