Improve document revision creation #5474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with changes fix: Write a document revision when 'Done editing' in edit mode
tommoor
commented
Jun 24, 2023
| @@ -203,6 +203,9 @@ export const DocumentsUpdateSchema = BaseSchema.extend({ | |||
|
|
|||
| /** Version of the API to be used */ | |||
| apiVersion: z.number().optional(), | |||
|
|
|||
| /** Whether the editing session is complete */ | |||
| done: z.boolean().optional(), | |||
There was a problem hiding this comment.
This was already passed from the client, but not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two scenarios it feels as though document revisions are created too late and will now be created sooner.