8000 Document emoji picker by apoorv-mishra · Pull Request #4338 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Document emoji picker #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 126 commits into from
Sep 3, 2023
Merged

Document emoji picker #4338

merged 126 commits into from
Sep 3, 2023

Conversation

apoorv-mishra
Copy link
Member
@apoorv-mishra apoorv-mishra commented Oct 25, 2022 •
edited by tommoor
Loading

image

Closes #4274

@apoorv-mishra apoorv-mishra force-pushed the feat/4274/emoji-picker branch from 0692e60 to bbcd85f Compare October 26, 2022 14:22
apoorv-mishra
apoorv-mishra commented Oct 27, 2022
View reviewed changes
apoorv-mishra
apoorv-mishra commented Oct 27, 2022
View reviewed changes
@apoorv-mishra apoorv-mishra force-pushed the feat/4274/emoji-picker branch from 96c9cc5 to a32c480 Compare October 29, 2022 17:31
tommoor
tommoor reviewed Nov 1, 2022
View reviewed changes
@apoorv-mishra apoorv-mishra force-pushed the feat/4274/emoji-picker branch from 0e0a560 to 6729b3a Compare November 3, 2022 10:08
@apoorv-mishra apoorv-mishra marked this pull request as ready for review November 3, 2022 12:04
@auto-assign auto-assign bot requested a review from tommoor November 3, 2022 12:04
tommoor

This comment was marked as outdated.

Sign in to view

@tommoor tommoor mentioned this pull request Nov 7, 2022
Closed
@apoorv-mishra
feat: add emoji-mart pkg and create Emoji component
0be9edd
@apoorv-mishra
feat(server): allow emoji to be updated and presented
a5f12a9
@apoorv-mishra
feat(app): make emoji observable and allow it to be updated
ddc7194
@apoorv-mishra
feat(app): create emoji picker component
c8f49b1
@apoorv-mishra
feat(app): sync picker theme with app theme
5edd09b
@apoorv-mishra
feat(app): use emoji picker alongside document title
4e55453
@apoorv-mishra
fix(app): make title optional for update
0113c6b
@apoorv-mishra
fix(app): update emoji only when changed
7a24b21
@apoorv-mishra
fix(app): animate placeholder emoji
00e5d9f
@apoorv-mishra
fix(app): typo
54c2f05
@apoorv-mishra
fix(app): display emoji in sidebar
79fbeaf
@apoorv-mishra
fix(app): make responsive
2263ff5
@apoorv-mishra
fix(app): make picker responsive
750055d
@apoorv-mishra
fix(app): use existing popover
3c27ea9
@apoorv-mishra
fix(app): disable scroll and fix popover width
def0f61
@apoorv-mishra
fix(app): conditionally render children
b87a9c7
@apoorv-mishra
fix(app): make picker available on title focus
37a5c6e
@apoorv-mishra
fix(app): stop bubbling on emoji button press
d717873
@apoorv-mishra
fix(app): replace store.update() with document.save()
d8c4454
@tommoor tommoor changed the title Ability to pick and choose emoji for the document Document emoji picker Aug 26, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 27, 2023
View reviewed changes
server/migrations/20230815063834-migrate-emoji-in-document-title.js
`server/scripts/${scriptName}`
);

execSync(`node ${scriptPath}`, { stdio: "inherit" });

Check warning

Code scanning / CodeQL

Shell command built from environment values

This shell command depends on an uncontrolled [absolute path](1).
tommoor
tommoor approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member
@tommoor tommoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally done here, please don't merge.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 28, 2023
View reviewed changes
server/migrations/20230827234031-migrate-emoji-in-revision-title.js
`server/scripts/${scriptName}`
);

execSync(`node ${scriptPath}`, { stdio: "inherit" });

Check warning

Code scanning / CodeQL

Shell command built from environment values

This shell command depends on an uncontrolled [absolute path](1).
@tommoor tommoor merged commit 1c7bb65 into main Sep 3, 2023
@tommoor tommoor deleted the feat/4274/emoji-picker branch September 3, 2023 13:11
@patzm
Copy link
patzm commented Sep 3, 2023

very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor tommoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add emoji picker for document title
3 participants
@apoorv-mishra @tommoor @patzm
0