8000 fix: Move request helper function by iamsaumya · Pull Request #2594 · outline/outline · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Move request helper function #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2021
Merged

fix: Move request helper function #2594

merged 3 commits into from
Sep 29, 2021

Conversation

iamsaumya
Copy link
Contributor

closes #2558

@auto-assign auto-assign bot requested a review from tommoor September 19, 2021 08:33
iamsaumya
iamsaumya commented Sep 19, 2021
View reviewed changes
@iamsaumya
Copy link
Contributor Author
iamsaumya commented Sep 19, 2021 •
edited
Loading

I couldn't think of any generalization apart from just returning response without calling .json(). Is this good? Is there any generalization that you want?

@tommoor
Copy link
Member
tommoor commented Sep 19, 2021

I think the intention of original issue was to use the same function for all of the passport strategies as it was essentially copy and pasted in 3 places

@tommoor
Copy link
Member
tommoor commented Sep 26, 2021

The same function is in all of the providers, not just Azure 😉

@iamsaumya
Copy link
Contributor Author

I went through the files, and it's not :(

He pointed out that contributors were copy-pasting the request method from azure in each of their PR. If we merge this, they will use this request method instead of duplicating. Apologies in advance if I have missed something.

@tommoor tommoor merged commit 0ed7286 into main Sep 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/2558 branch September 29, 2021 14:20
almereyda added a commit to almereyda/outline that referenced this pull request Oct 4, 2021
@almereyda
auth(GitLab): remove request helper function (outline#2594)
c6b7287
@almereyda almereyda mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommoor tommoor Awaiting requested review from tommoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DRY pattern for authentication providers : generalise and refactor request helper function
2 participants
@iamsaumya @tommoor
0