Comment link lost #6011
Comments
|
I cannot reproduce with your steps, so as you say there must be more to it. The marker in the content is stored as part of the Your symptoms would suggest that the edit to the state was not persisted for some reason, if you can reproduce and get server logs that might help. |
|
It seems that if the commenting user has only View permissions, then the marker for the resulting comment will not be visible to anyone except that user. |
|
This sounds like it could be the issue, the comment on a text functionality should be unavailable to viewers. |
I think viewers also need to have comment functions. For example, when we publish an instruction manual to users, they need a channel for feedback. |
|
Viewers can still comment on the document from the sidebar, but it's a limitation that they cannot comment on text for now as it actually modifies the document. |
Would there be any reason not to allow this? |
|
Not from a product point of view, it's mainly a technical limitation. To keep the focus on this issue, if there is a way to create a text selection comment as a viewer then that would be the bug here for now. |
…30dfb (#15817) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [outlinewiki/outline](https://togithub.com/outline/outline) | minor | `0.73.1` -> `0.74.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>outline/outline (outlinewiki/outline)</summary> ### [`v0.74.0`](https://togithub.com/outline/outline/releases/tag/v0.74.0) [Compare Source](https://togithub.com/outline/outline/compare/v0.73.1...v0.74.0) **Note:** Minimum Node version changed to 18 – if using Docker installation this is handled for you. ##### Improvements - Clicking on a link while editing will now automatically select the entire link - Mermaid diagrams are now rendered in HTML exports in [https://github.com/outline/outline/issues/6205](https://togithub.com/outline/outline/issues/6205) - Added "Share" option to document menu on mobile - New translations - Updated to Node 20 LTS - \[API] `comments.list` endpoint can now be used without a document ID ##### Fixes - Find and replace dialog no longer gets stuck without replace button - Fixed corruption in imports in [https://github.com/outline/outline/pull/6162](https://togithub.com/outline/outline/pull/6162) - Fixed recurring crash when DataDog and Sentry are enabled. - Fixed display of video nodes in document history - Fixed members can now create templates again - Fixed viewing public shares failed if user has an expired token in [https://github.com/outline/outline/pull/6134](https://togithub.com/outline/outline/pull/6134) - Restored ability to comment in code blocks in [https://github.com/outline/outline/issues/6154](https://togithub.com/outline/outline/issues/6154) - Comment functionality should not show in toolbar for view-only users in [https://github.com/outline/outline/issues/6011](https://togithub.com/outline/outline/issues/6011) - Added support for tldraw snapshot links in [https://github.com/outline/outline/pull/6210](https://togithub. 8000 com/outline/outline/pull/6210) - Restored PWA install in recent Chrome versions - Fixed extra empty page in HTML exports in [https://github.com/outline/outline/issues/6205](https://togithub.com/outline/outline/issues/6205) - Emoji in template titles are now applied correctly in [https://github.com/outline/outline/issues/6169](https://togithub.com/outline/outline/issues/6169) - Many dependency updates #### New Contributors - [@​NextFire](https://togithub.com/NextFire) made their first contribution in [https://github.com/outline/outline/pull/6134](https://togithub.com/outline/outline/pull/6134) - [@​EspadaV8](https://togithub.com/EspadaV8) made their first contribution in [https://github.com/outline/outline/pull/6217](https://togithub.com/outline/outline/pull/6217) - [@​RayYH](https://togithub.com/RayYH) made their first contribution in [https://github.com/outline/outline/pull/6238](https://togithub.com/outline/outline/pull/6238) **Full Changelog**: outline/outline@v0.73.1...v0.74.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44OC4yIiwidXBkYXRlZEluVmVyIjoiMzcuODguMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9-->
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [outlinewiki/outline](https://github.com/outline/outline) | minor | `0.73.1` -> `0.74.0` | --- ### Release Notes <details> <summary>outline/outline (outlinewiki/outline)</summary> ### [`v0.74.0`](https://github.com/outline/outline/releases/tag/v0.74.0) [Compare Source](outline/outline@v0.73.1...v0.74.0) **Note:** Minimum Node version changed to 18 – if using Docker installation this is handled for you. ##### Improvements - Clicking on a link while editing will now automatically select the entire link - Mermaid diagrams are now rendered in HTML exports in outline/outline#6205 - Added "Share" option to document menu on mobile - New translations - Updated to Node 20 LTS - \[API] `comments.list` endpoint can now be used without a document ID ##### Fixes - Find and replace dialog no longer gets stuck without replace button - Fixed corruption in imports in outline/outline#6162 - Fixed recurring [OOM crash](https://twitter.com/tommoor/status/1730985110806184265) when DataDog and Sentry are enabled. - Fixed display of video nodes in document history - Fixed members can now create templates again - Fixed viewing public shares failed if user has an expired token in outline/outline#6134 - Restored ability to comment in code blocks in outline/outline#6154 - Comment functionality should not show in toolbar for view-only users in outline/outline#6011 - Added support for tldraw snapshot links in outline/outline#6210 - Restored PWA install in recent Chrome versions - Fixed extra empty page in HTML exports in outline/outline#6205 - Emoji in template titles are now applied correctly in outline/outline#6169 - Many dependency updates #### New Contributors - [@​NextFire](https://github.com/NextFire) made their first contribution in outline/outline#6134 - [@​EspadaV8](https://github.com/EspadaV8) made their first contribution in outline/outline#6217 - [@​RayYH](https://github.com/RayYH) made their first contribution in outline/outline#6238 **Full Changelog**: outline/outline@v0.73.1...v0.74.0 </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciJ9--> Co-authored-by: Renovate Bot <bot@renovateapp.com> Reviewed-on: https://gitea.bui.services/calvinbui/ansible-monorepo/pulls/2031 Co-authored-by: renovate <renovate@noreply.gitea.bui.services> Co-committed-by: renovate <renovate@noreply.gitea.bui.services>
@tommoor Do you plan to add this feature sometime in the near future? It would be really helpful, especially when the team is working on large documentation. |
It doesn't happen necessarily, but it happens often.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
specific content(such as Note) is a comment by account B.
Screenshots
account A:
account B:
Outline (please complete the following information):
Desktop (please complete the following information):
Through the console, I found that the
comment-markerwill be added to the commented content. This does not exist when it is not a comment.I queried the database and found the
documentsandcommentstables, but it seems that the mapping relationship between comments and corresponding content is not recorded in it. How is the comment function implemented?The text was updated successfully, but these errors were encountered: