8000 Fix the remainder of our configs by wizeng23 · Pull Request #1356 · oumi-ai/oumi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the remainder of our configs #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix the remainder of our configs #1356

merged 3 commits into from
Feb 4, 2025

Conversation

wizeng23
Copy link
Contributor
@wizeng23 wizeng23 commented Feb 4, 2025

Description

This PR fixes our configs which don't have an associated job config (mostly inference configs).

Related issues

Fixes OPE-818

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

nikg4
nikg4 reviewed Feb 4, 2025
View reviewed changes
configs/recipes/llama3_1/sft/8b_full/longctx_train.yaml
@@ -47,6 +47,8 @@ data:
- dataset_name: "HuggingFaceFW/fineweb-edu"
subset: "sample-10BT"
split: "train"
dataset_kwargs:
seq_length: 32_768
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For general info: curious how 32_768 notation is supported: is it done by YAML or Python ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly, copied what was above (which I think is from Oussama)

@wizeng23 wizeng23 merged commit 9adf625 into main Feb 4, 2025
2 checks passed
@wizeng23 wizeng23 deleted the wizeng/checkconfigs branch February 4, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oelachqar oelachqar oelachqar approved these changes

@taenin taenin taenin approved these changes

@nikg4 nikg4 nikg4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wizeng23 @oelachqar @taenin @nikg4
0