Update Phi3 to support multiple images #1321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- Update
phi3-instructchat template to support multiple images-- Add test to verify that Oumi's
phi3-instructtemplate output is the same as for original built-in model template for text-only (can't do it for images as the original chat template is text-only)-- Add test to verify the
phi3-instructoutput for multimodal conversation is as expected-- Rename some vars in
vision_language_dataset.pyfor clarifyRelated issues
Fixes OPE-575
Towards OPE-355
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.