8000 Fix a bug where overriding remote_params fails via the CLI (oumi infer) by taenin · Pull Request #1487 · oumi-ai/oumi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix a bug where overriding remote_params fails via the CLI (oumi infer) #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2025
Merged

Fix a bug where overriding remote_params fails via the CLI (oumi infer) #1487

merged 3 commits into main from
Feb 27, 2025

Conversation

taenin
Copy link
Collaborator
@taenin taenin commented Feb 26, 2025

Description

During inference, oumi infer would fail if the user specified any remote_params via the CLI for wrapper engines (engines that inherit from the RemoteInferenceEngine). This is because the merged config specified at inference time had None values for required API fields.

Updated the infer method to gracefully fallback to previous values if None values are detected at runtime.

Related issues

N/A

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@taenin taenin marked this pull request as ready for review February 26, 2025 22:29
@taenin taenin merged commit 51b82d4 into main Feb 27, 2025
2 checks passed
@taenin taenin deleted the taenin/remote_override branch February 27, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oelachqar oelachqar oelachqar approved these changes

@wizeng23 wizeng23 wizeng23 approved these changes

@jgreer013 jgreer013 Awaiting requested review from jgreer013

@nikg4 nikg4 Awaiting requested review from nikg4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taenin @oelachqar @wizeng23
0