8000 Minor cleanup of oumi fetch by taenin · Pull Request #1463 · oumi-ai/oumi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Minor cleanup of oumi fetch #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2025
Merged

Minor cleanup of oumi fetch #1463

merged 3 commits into from
Feb 20, 2025

Conversation

taenin
Copy link
Collaborator
@taenin taenin commented Feb 20, 2025

Description

I've slightly refactored the oumi fetch logic to live in cli_utils to make testing a bit easier.
I've also removed the output_dir argument from the oumi infer cli as it was unclear that it was for downloading configs.

I also updated oumi fetch to fetch configs if the user omits the oumi:// prefix.

Related issues

Related to #1386

Before submitting

  • This PR only changes documentation. (You can ignore the following checks in that case)
  • Did you read the contributor guideline Pull Request guidelines?
  • Did you link the issue(s) related to this PR in the section above?
  • Did you add / update tests where needed?

Reviewers

At least one review from a member of oumi-ai/oumi-staff is required.

@taenin taenin marked this pull request as ready for review February 20, 2025 23:16
@taenin taenin requested review from wizeng23 and oelachqar February 20, 2025 23:17
wizeng23
wizeng23 reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor
@wizeng23 wizeng23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind addressing my comments in #1439, if they make sense to you?

src/oumi/cli/infer.py
@@ -33,16 +32,6 @@ def infer(
help="Path to the configuration file for inference.",
),
],
output_dir: Annotated[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some other name for the flag that you think will be more clear? Also fine to delete if you feel that it's not likely to be set

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for all entrypoints excepts oumi fetch we should use the env_var to determine this value. No need for the param here.

@taenin
Copy link
Collaborator Author
taenin commented Feb 20, 2025

Do you mind addressing my comments in #1439, if they make sense to you?

I'll leave these for now in case the original author is working on them!

@taenin taenin merged commit b46adc6 into main Feb 20, 2025
2 checks passed
@taenin taenin deleted the taenin/fetch_cleanup branch February 20, 2025 23:28
This was referenced Feb 21, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizeng23 wizeng23 wizeng23 approved these changes

@oelachqar oelachqar Awaiting requested review from oelachqar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taenin @wizeng23
0