fix(module-federation): ensure manifest path not prepended with workspace root #31698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit b136f72.
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When users provide an absolute path for the Module Federation manifest file
that already includes the workspace root, the plugin incorrectly prepends the
workspace root again, resulting in an invalid path like
/workspace/root/workspace/root/path/to/manifest.json.Expected Behavior
The plugin should detect if the provided manifest file path already starts with
the workspace root and avoid prepending it again. This allows users to provide
either relative or absolute paths for the manifest file, and both will work
correctly.
Related Issue(s)
Fixes #31524