8000 feat(angular): use consistent artifact generation for generators by Coly010 · Pull Request #19601 · nrwl/nx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(angular): use consistent artifact generation for generators #19601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat(angular): use consistent artifact generation for generators #19601

merged 1 commit into from
Oct 13, 2023

Conversation

Coly010
Copy link
Contributor
@Coly010 Coly010 commented Oct 13, 2023

Current Behavior

Angular generators have an inconsistent method for generating artifacts for generators

Expected Behavior

Make the generation of artifacts consistent

Related Issue(s)

Fixes #

@Coly010 Coly010 requested review from a team as code owners October 13, 2023 14:10
@Coly010 Coly010 requested a review from leosvelperez October 13, 2023 14:10
@Coly010 Coly010 self-assigned this Oct 13, 2023
@Coly010 Coly010 requested a review from isaacplmann October 13, 2023 14:10
@vercel
Copy link
vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 13, 2023 3:18pm

@nx-cloud
Copy link
Contributor
nx-cloud bot commented Oct 13, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5b8f95b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@Coly010 Coly010 force-pushed the feat/angular-consistent-artifacts-generation branch from 1f3b61d to 3494ecb Compare October 13, 2023 14:54
@Coly010 Coly010 force-pushed the feat/angular-consistent-artifacts-generation branch from 3494ecb to 5b8f95b Compare October 13, 2023 15:12
@Coly010 Coly010 enabled auto-merge (squash) October 13, 2023 15:59
@Coly010 Coly010 merged commit 5a6adb7 into nrwl:master Oct 13, 2023
@Coly010 Coly010 deleted the feat/angular-consistent-artifacts-generation branch October 13, 2023 16:25
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

@leosvelperez leosvelperez Awaiting requested review from leosvelperez leosvelperez is a code owner automatically assigned from nrwl/nx-angular-reviewers

@isaacplmann isaacplmann Awaiting requested review from isaacplmann isaacplmann is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees

@Coly010 Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coly010 @jaysoo
0