8000 cleanup(misc): rename builders.json to executors.json by leosvelperez · Pull Request #6230 · nrwl/nx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cleanup(misc): rename builders.json to executors.json #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021
Merged

cleanup(misc): rename builders.json to executors.json #6230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/angular/executors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
[
"angular",
"cypress",
"express",
"gatsby",
"jest",
"linter",
"nest",
"next",
"node",
"nx-plugin",
Expand Down
2 changes: 0 additions & 2 deletions docs/node/executors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
[
"angular",
"cypress",
"express",
"gatsby",
"jest",
"linter",
"nest",
"next",
"node",
"nx-plugin",
Expand Down
2 changes: 0 additions & 2 deletions docs/react/executors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
[
"angular",
"cypress",
"express",
"gatsby",
"jest",
"linter",
"nest",
"next",
"node",
"nx-plugin",
Expand Down
5 changes: 5 additions & 0 deletions packages/angular/builders.json → packages/angular/executors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
"implementation": "./src/executors/package/package.impl",
"schema": "./src/executors/package/schema.json",
"description": "Builds and packages an Angular library to be distributed as an NPM package. It supports incremental builds."
},
"webpack-browser": {
"implementation": "./src/builders/webpack-browser/webpack-browser.impl",
"schema": "./src/builders/webpack-browser/schema.json",
"description": "Builds a browser application with support for incremental builds and custom webpack configuration."
}
},
"builders": {
Expand Down
2 changes: 1 addition & 1 deletion packages/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"url": "https://github.com/nrwl/nx/issues"
},
"homepage": "https://nx.dev",
"builders": "./builders.json",
"builders": "./executors.json",
"schematics": "./collection.json",
"ng-update": {
"requirements": {},
Expand Down
4 changes: 0 additions & 4 deletions packages/express/builders.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/express/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json"
Expand Down
0 packages/gatsby/builders.json → packages/gatsby/executors.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/gatsby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"builders": "./executors.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json"
Expand Down
0 packages/linter/builders.json → packages/linter/executors.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/linter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"requirements": {},
"migrations": "./migrations.json"
},
"builders": "./builders.json",
"builders": "./executors.json",
"dependencies": {
"@nrwl/devkit": "*",
"glob": "7.1.4",
Expand Down
4 changes: 0 additions & 4 deletions packages/nest/builders.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/nest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json"
Expand Down
0 packages/next/builders.json → packages/next/executors.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"builders": "./executors.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json"
Expand Down
0 packages/node/builders.json → packages/node/executors.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"builders": "./executors.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json"
Expand Down
0 packages/storybook/builders.json → packages/storybook/executors.json
View file
Open in desktop
File renamed without changes.
CEB7
2 changes: 1 addition & 1 deletion packages/storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"builders": "./executors.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json"
Expand Down
0 packages/web/builders.json → packages/web/executors.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"builders": "./executors.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json"
Expand Down
6 changes: 2 additions & 4 deletions packages/workspace/builders.json → packages/workspace/executors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"run-script": {
"implementation": "./src/executors/run-script/compat",
"schema": "./src/executors/run-script/schema.json",
"description": "Run an npm script using Nx",
"hidden": true
"description": "Run an npm script using Nx"
}
},
"executors": {
Expand All @@ -38,8 +37,7 @@
"run-script": {
"implementation": "./src/executors/run-script/run-script.impl",
"schema": "./src/executors/run-script/schema.json",
"description": "Run an npm script using Nx",
"hidden": true
"description": "Run an npm script using Nx"
}
}
}
2 changes: 1 addition & 1 deletion packages/workspace/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"homepage": "https://nx.dev",
"schematics": "./collection.json",
"builders": "./builders.json",
"builders": "./executors.json",
"ng-update": {
"requirements": {},
"migrations": "./migrations.json",
Expand Down
12 changes: 4 additions & 8 deletions scripts/documentation/generate-executors-data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@ import { createSchemaFlattener, SchemaFlattener } from './schema-flattener';
const flattener = createSchemaFlattener([pathFormat, htmlSelectorFormat]);

function readExecutorsJson(root: string) {
try {
return readJsonSync(join(root, 'builders.json')).builders;
} catch (e) {
return readJsonSync(join(root, 'executors.json')).executors;
}
return readJsonSync(join(root, 'executors.json')).executors;
}

function generateSchematicList(
Expand Down Expand Up @@ -173,9 +169,9 @@ export async function generateExecutorsDocumentation() {
generateSchematicList(config, flattener)
);

const markdownList = buildersList.map((b) =>
generateTemplate(framework, b)
);
const markdownList = buildersList
.filter((b) => b != null && !b['hidden'])
.map((b) => generateTemplate(framework, b));

await Promise.all(
markdownList.map((template) =>
Expand Down
4 changes: 1 addition & 3 deletions scripts/documentation/get-package-configurations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ export function getPackageConfigurations(
framework,
builderOutput: path.join(output, 'executors'),
schematicOutput: path.join(output, 'generators'),
hasBuilders:
itemList.includes('builders.json') ||
itemList.includes('executors.json'),
hasBuilders: itemList.includes('executors.json'),
hasSchematics:
itemList.includes('collection.json') ||
itemList.includes('generators.json'),
Expand Down
0