8000 docs(angular): fix links in migrating from angular cli docs by Coly010 · Pull Request #6228 · nrwl/nx · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(angular): fix links in migrating from angular cli docs #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2021
Merged

docs(angular): fix links in migrating from angular cli docs #6228

merged 1 commit into from
Jul 2, 2021

Conversation

Coly010
Copy link
Contributor
@Coly010 Coly010 commented Jul 2, 2021

Some of the links were broken in this pages's docs.

Use {{framework}} to ensure pages are resolved correctly.

@Coly010 Coly010 self-assigned this Jul 2, 2021
@vercel
Copy link
vercel bot commented Jul 2, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nrwl/nx-dev/CBWFHCXNmEsZUdYzZqLVS3Wyv6r7
✅ Preview: https://nx-dev-git-fork-coly010-fix-angular-migration-docs-nrwl.vercel.app

@nx-cloud
Copy link
nx-cloud bot commented Jul 2, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 4acdc6e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx affected --target=build --base=e7a1cd2c9139900872869b6c7ddef612696c409c --parallel --max-parallel=3
#000000 nx affected --target=e2e --base=e7a1cd2c9139900872869b6c7ddef612696c409c
#000000 nx affected --target=lint --base=e7a1cd2c9139900872869b6c7ddef612696c409c --parallel --max-parallel=4
#000000 nx affected --target=test --base=e7a1cd2c9139900872869b6c7ddef612696c409c --parallel --max-parallel=2
#000000 nx build typedoc-theme

Sent with 💌 from NxCloud.

leosvelperez
leosvelperez reviewed Jul 2, 2021
View reviewed changes
@Coly010
docs(angular): fix links in migrating from angular cli docs
4acdc6e 
Refactor Angular Application Schematic to Generator using Nx Devkit
@Coly010 Coly010 force-pushed the fix-angular-migration-docs branch from 724bd21 to 4acdc6e Compare July 2, 2021 11:48
@Coly010 Coly010 requested a review from leosvelperez July 2, 2021 12:44
leosvelperez
leosvelperez approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member
@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Coly010 Coly010 merged commit d6d142e into nrwl:master Jul 2, 2021
@Coly010 Coly010 deleted the fix-angular-migration-docs branch July 2, 2021 13:57
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leosvelperez leosvelperez leosvelperez approved these changes

@brandonroberts brandonroberts Awaiting requested review from brandonroberts

Assignees

@Coly010 Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coly010 @leosvelperez
0