8000 chore: fix lint-staged on Windows by jstarpl · Pull Request #242 · nrkno/sofie-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: fix lint-staged on Windows #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020
Merged

chore: fix lint-staged on Windows #242

merged 1 commit into from
Jun 4, 2020

Conversation

jstarpl
Copy link
Member
@jstarpl jstarpl commented Jun 2, 2020
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This fixes a workflow bug where lint-staged could produce commands that are too long for the Windows shell to work.

  • What is the current behavior? (You can also link to an open issue here)

The lint-staged can fail if there are a lot of files staged. meteor npm run quickformat won't work at all on Windows.

  • Other information:

Status

  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@jstarpl jstarpl requested a review from Julusian June 2, 2020 09:25
@jstarpl jstarpl mentioned this pull request Jun 2, 2020
Copy link
Contributor
@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to use this for now, but I think we should check if the default lint-staged is good enough for the meteor 1.10 branch, as newer versions claim to already do chunking https://github.com/okonet/lint-staged/releases/tag/v10.0.0

@jstarpl jstarpl merged commit 761f927 into master Jun 4, 2020
@Julusian Julusian deleted the chore/fixLintStaged branch June 4, 2020 14:06
chrisryanouellette pushed a commit to SuperFlyTV/sofie-core that referenced this pull request Jun 11, 2020
nytamin pushed a commit that referenced this pull request Jun 16, 2020
ianshade added a commit to ianshade/tv-automation-server-core that referenced this pull request Jun 9, 2023
…downs

fix: SOF-1424 prevent duplicated options in dropdowns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0