8000 feat(webui): improve Bootstrap theme (SOFIE-3880) by jstarpl · Pull Request #1446 · nrkno/sofie-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(webui): improve Bootstrap theme (SOFIE-3880) #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025

Conversation

jstarpl
Copy link
Member
@jstarpl jstarpl commented May 7, 2025

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Feature

Current Behavior

New Behavior

This PR applies some styling tweaks that smooth out the switch-over to Bootstrap.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Not urgent, but we would like to get this merged into the in-development release.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner May 7, 2025 09:01
@jstarpl jstarpl changed the title feat: improve Bootstrap theme (SOFIE-3880) feat(webui): improve Bootstrap theme (SOFIE-3880) May 7, 2025
Copy link
codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.15%. Comparing base (02b7a01) to head (0e12c50).
Report is 1 commits behind head on release53.

Additional details and impacted files
@@              Coverage Diff              @@
##           release53    #1446      +/-   ##
=============================================
+ Coverage      54.05%   54.15%   +0.09%     
=============================================
  Files            404      404              
  Lines          73586    73586              
  Branches        5369     4963     -406     
=============================================
+ Hits           39780    39850      +70     
+ Misses         33662    33644      -18     
+ Partials         144       92      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jstarpl jstarpl merged commit df6f8a2 into release53 May 7, 2025
69 checks passed
@jstarpl jstarpl deleted the feat/sofie-3880/improve-bootstrap-theme branch May 7, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0