8000 chore(webui): misc ui refactorings by Julusian · Pull Request #1434 · nrkno/sofie-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(webui): misc ui refactorings #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 8, 2025
Merged

chore(webui): misc ui refactorings #1434

merged 4 commits into from
May 8, 2025

Conversation

Julusian
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of myself

Type of Contribution

This is a: Code improvement

New Behavior

This is a bundle of a few changes:

  • Refactor a couple of components to be functional
  • Remove remaining usages of react-timer-hoc, replacing with our existing useCurrentTime hook
  • Adjust RundownViewEventBus to use newer approach for typings, and add hook wrapper

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.
    …entBusListener` helper

@Julusian Julusian force-pushed the feat/simplify-rundownViewEventBus branch from c3e4ca2 to 7b46c81 Compare April 16, 2025 11:40
@Julusian Julusian marked this pull request as ready for review April 16, 2025 11:41
@Julusian Julusian requested a review from a team as a code owner April 16, 2025 11:41
@codecov Codecov
Copy link
codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (c61bec6) to head (8a50457).
Report is 51 commits behind head on release53.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release53    #1434      +/-   ##
=============================================
+ Coverage      54.00%   54.13%   +0.13%     
=============================================
  Files            404      404              
  Lines          73586    73586              
  Branches        5365     5367       +2     
=============================================
+ Hits           39737    39834      +97     
+ Misses         33721    33623      -98     
- Partials         128      129       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Julusian Julusian mentioned this pull request Apr 16, 2025
Merged
7 tasks
@jstarpl jstarpl added the Contribution External contribution label Apr 18, 2025
@jstarpl jstarpl changed the title chore: misc ui refactorings chore(webui): misc ui refactorings May 7, 2025
@nytamin nytamin merged commit 2c2e521 into nrkno:release53 May 8, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytamin nytamin nytamin approved these changes

Assignees
No one assigned
Labels
Contribution External contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Julusian @nytamin @jstarpl
0