8000 chore: add timeout for citgm command step by lukekarrys · Pull Request #6149 · npm/cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: add timeout for citgm command step #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

lukekarrys
Copy link
Contributor

This also adds a final step that will always run to set the exit code for the citgm
job in the case of the command step timing out during known failures

@lukekarrys lukekarrys requested a review from a team as a code owner February 8, 2023 17:04
@lukekarrys lukekarrys requested review from nlf and removed request for a team February 8, 2023 17:04
Copy link
Contributor
@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% makes sense to me

This also adds a final step that will always run to set the exit code for the citgm
job in the case of the command step timing out during known failures
@lukekarrys lukekarrys force-pushed the lk/node-integration-timeout branch from a6dbedb to 81dfaca Compare February 8, 2023 17:10
@lukekarrys lukekarrys merged commit c606653 into latest Feb 8, 2023
@lukekarrys lukekarrys deleted the lk/node-integration-timeout branch February 8, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0