Direct messages #42
Merged
Direct messages #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Work-in-progress.
… messages component
…ryption - Added MessagingService to manage direct messages, including loading chats and processing incoming messages. - Introduced interfaces for Chat and DirectMessage to structure message data. - Integrated EncryptionService for message decryption using NIP-04 and NIP-17 protocols. - Implemented a decryption queue to handle message decryption sequentially. - Enhanced auto-decrypt functionality to support different encryption types. - Added unit tests for MessagingService to ensure proper functionality.
…ading conditions in UserProfileComponent
…t out min-width properties in chat list container
…ing. .chat-content-container needs width 100% to ensure no horizontal scrolling.
…age publishing and event handling
…st visibility conditions
…Chat computed property
There was a problem hiding this comment.
Pull Request Overview
This PR introduces direct messaging functionality by updating services for relay and encryption, revamping message UI components, and adding tests.
- Updated user and account relay services to decouple relay URL retrieval.
- Enhanced encryption service handling legacy (NIP-04) and modern (NIP-44) encryption algorithms.
- Modified messages components (SCSS and HTML) to align with new Angular flow syntax and UI requirements, and updated copilot instructions regarding Angular version and Angular Material variables.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/app/services/user-relay.service.ts | Updated relay URL fetching and added a new publish method for events. |
| src/app/services/nostr.service.ts | Removed redundant account relay computations and debugger statements. |
| src/app/services/messaging.service.spec.ts | Added basic test for MessagingService creation. |
| src/app/services/encryption.service.ts | Introduced encryption and decryption methods for both legacy and modern algorithms. |
| src/app/services/account-relay.service.ts | Added methods for querying and subscribing to Nostr events via account relays. |
| src/app/pages/messages/messages.component.scss | Adjusted layout dimensions and styling updates for messages and warnings. |
| src/app/pages/messages/messages.component.html | Updated template syntax and improved chat list and message input structure. |
| src/app/components/user-profile/user-profile.component.ts | Minor refactoring for handling pubkey changes using effects. |
| .github/copilot-instructions.md | Revised Angular project version and Angular Material CSS variable usage notes. |
Comments suppressed due to low confidence (1)
.github/copilot-instructions.md:1
- The copilot instructions now indicate Angular 19, which conflicts with the custom coding guidelines that specify Angular 20. Update the instructions to reflect the correct Angular version to avoid confusion during development.
This is an Angular 19 project, make sure to always use signals and effects. Also always use most modern TypeScript, with async/await.
…oss messaging components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.