-
Notifications
You must be signed in to change notification settings - Fork 650
Expand NIP-24 to support organization flag and fields on Kind 0 notes. #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added many fields to user metadata to make possible many useful features for businesses and other organization accounts.
I'm fine with this in principle, but I would put the address stuff at the top level rather than nested under org info. Also, maybe a "type" field with some options would be better than a boolean. Is this implemented anywhere? |
I thought of that, but I thought it would be better for address stuff to stay exclusive to orgs. Otherwise I can see a scenario where most client devs just give you an address input as part of your sign up process, then users from centralized platforms just enter their address because they are used to giving info to companies, not realizing they are doxxing their exact home address to everyone. And to be honest, I don't think any individual user should, or wants to, have their street address in their public profile.
Honestly I considered it would be simpler to just check the existence of an orgInfo object rather than require a flag. Or moving the orgType field to the top level would work just as well. It just felt cleaner this way.
No. |
Better use a new kind, like |
Curious why you think it won't interest 99% of users.
When developing, devs will look at all the fields and handle them all, if in kind 0, but if it's a different kind, only devs for business specific apps will use it. I think address and sector is important enough that every new client should show it in some way, even if they just concat the fields into the bio. The address of a physical business or local organization is relevant to 99% of the people who open their profile, not the other way around. It is nice that it can enable the creation of many new apps, but even just for a Twitter clone it's essential info so I think putting it in kind 0 is better. |
In the context of a microblogging app if you just happen to see a post by some restaurant it is very unlikely that you're planning on going to that restaurant tonight, so the address is completely unnecessary. Remember that the And even if you click on someone's microblogging post that doesn't mean you want to visit them. In the context of an app about restaurants or restaurant reviews or geotagging etc that is different of course. I agree with you that birthdays shouldn't be here. In fact most fields shouldn't be here. I disagree that having this field will stop restaurants from writing their address in their A flag on |
Added many fields to user metadata to make possible many useful features for businesses and other organization accounts.