Add Diff and Permalink kinds #1875
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new kinds of git events, intended to be drop-in replacements for GitHub permalinks and diff links respectively. The purpose of these kinds is to enable conversations and comments about specific lines of code, either in a given commit or the diff of two commits. These kinds are distinct from the code snippet kind introduced in NIP-C0 as the content of the events are not intended to be executable rather to directly reference code or documentation in a Git repo precisely and immutably.
These kinds are already in use by the Flotilla-Budabit fork.