-
Notifications
You must be signed in to change notification settings - Fork 4
ci: adding publish script #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 14d190f in 56.022708 seconds
More details
- Looked at
109lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. .github/workflows/npm-publish.yml:12
- Draft comment:
Consider updatingactions/checkoutto the latest version (v3) to ensure compatibility and security.
- uses: actions/checkout@v3
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
2. .github/workflows/npm-publish.yml:17
- Draft comment:
Consider updatingactions/setup-nodeto the latest version (v3) to ensure compatibility and security.
uses: actions/setup-node@v3
- Reason this comment was not posted:
Confidence of 40% on close inspection, compared to threshold of 50%.
3. .github/workflows/npm-publish.yml:19
- Draft comment:
Consider using the latest LTS version of Node.js to ensure better performance, security, and compatibility.
node-version: '18' # Latest LTS version
- Reason this comment was not posted:
Confidence of 40% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_uvFIEX2OFs4EDypt
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on d035226 in 39.905803 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_YNjWPls1ubgMR2vD
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Futzing with publication patterns
Summary:
Consolidate GitHub Actions workflow to a single job for bumping version and publishing pre-releases using
release-please.Key points:
publish-next-tag-versionjob in.github/workflows/npm-publish.yml.publish-nextandpublish-releasejobs.release-pleaseto determine the next version.package.jsonwith the new version and publish with--preid=next.actions/checkouttov2andactions/setup-nodetov2.20.Generated with ❤️ by ellipsis.dev