handle no datum id #380
Draft
handle no datum id #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b847ff1 to
affdc46
Compare
| tb = feather.read_table( | ||
| self.projection.tile_destination / Path(key).with_suffix(".datum_id.feather"), memory_map=True | ||
| ) | ||
| try: |
There was a problem hiding this comment.
DRY: Repeated try/except blocks for reading datum id feather files. Consider extracting a helper to avoid duplicating fallback logic.
| @@ -675,7 +721,7 @@ def __init__(self, projection: "AtlasProjection", auto_cleanup: Optional[bool] = | |||
| try: | |||
| self.projection._download_sidecar("datum_id") | |||
| except Exception: | |||
| raise ValueError("Failed to fetch datum ids which is required to load tags.") | |||
| id_sidecar = self.projection._get_sidecar_from_field(self.id_field) | |||
There was a problem hiding this comment.
Review fallback behavior in AtlasMapTags.__init__: In the exception block, only id_sidecar is assigned without using it to download the sidecar. Should this mirror the approach used elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Adds exception handling and fallback logic for missing 'datum_id' in
nomic/data_operations.pyand updates version insetup.py._load_duplicates(),_load_topics(),tb(),df(),get_datums_in_tag(), and_load_data()innomic/data_operations.pyto handle missing.datum_id.featherfiles..datum_id.featheris missing.setup.pyfrom3.4.1to3.4.2.This description was created by
for affdc46. It will automatically update as commits are pushed.